search

Bariskas / oop

Лабораторные по ООП 2 курс ИПС
0 stars 0 forks source link

Замечания по фигурам #7

Open alexey-malov opened 7 years ago

alexey-malov commented 7 years ago 
V813 Decreased performance. The 'from', 'to' arguments should probably be rendered as constant references. Shapes ctextformcanvas.cpp 16
V813 Decreased performance. The 'points' argument should probably be rendered as a constant reference. Shapes ctextformcanvas.cpp 22
V813 Decreased performance. The 'center' argument should probably be rendered as a constant reference. Shapes ctextformcanvas.cpp 32
V813 Decreased performance. The 'center' argument should probably be rendered as a constant reference. Shapes ctextformcanvas.cpp 38
V813 Decreased performance. The 'colorString' argument should probably be rendered as a constant reference. Shapes sfmlutils.cpp 6
V813 Decreased performance. The 'point1', 'point2' arguments should probably be rendered as constant references. Shapes shapeutils.cpp 5
V808 'st' object of 'basic_string' type was created but was not utilized. Shapes_test circletests.cpp 65
alexey-malov commented 7 years ago 
void CTextFormCanvas::Display()
{
    m_outputStream << "Display some shit." << endl;
}
alexey-malov commented 7 years ago
alexey-malov commented 7 years ago 
class CSolidShapeBase : public ISolidShape, public CShapeBase
{
public:
    virtual ~CSolidShapeBase() {};
    CSolidShapeBase(std::string outlineColor, std::string fillColor);
    std::string GetFillColor() const override;

    virtual std::string ToString() const override final;
    virtual std::string GetOutlineColor() const override final;

private:
    std::string m_fillColor;
};
std::string CSolidShapeBase::ToString() const
{
    return CShapeBase::ToString();
}

std::string CSolidShapeBase::GetOutlineColor() const
{
    return CShapeBase::GetOutlineColor();
}
alexey-malov commented 7 years ago
alexey-malov commented 7 years ago