newspaper/OSD issue display

[MarthaTenney]

OSD is not displaying on newspaper issue pages (e.g. http://digitalcollections.barnard.edu/object/bulletin-19010401/barnard-bulletin-april-1-1901); it is displaying on newspaper page pages (e.g. http://digitalcollections.barnard.edu/object/bulletin-19010401-3/barnard-bulletin-april-1-1901-page-3)

[br2490]

@MarthaTenney this is ready for testing on islandoradev. We have updated our OSD paged module.

Things that should be working:

• [x] Newspaper Display
• [x] Paging, etc.
• [x] Search on individual page results highlight.

Things I've noticed still not working:

• [x] Search results on the "issue object" rather than "page objects" do NOT highlight 👎

@TODO:

• [x] Search results on Newspaper objs.

highlighting results e.g.: http://islandoradev/islandora/search/catch_all_fields_mt%3A%28LINDA%29?islandora_solr_search_navigation=0&f%5B0%5D=mods_genre_ms%3A%22newspaper%22

[br2490]

@MarthaTenney this has been deployed to production. Please let me know if there are any outstanding issues :)

auto closed by merge, reopening.

Thank you, Martha!

[MarthaTenney]

Looking good to me! I don't think the highlight not working on the issue object is a bug--the HOCR is stored on the page level so that's where the highlighting should work, right? And most of the results should be page-level as well. Can you easily explain what was going wrong for OSD to not display?

Thank you, Ben!

[br2490]

I can confirm that may indeed have been a bug; highlighting on mutlipage OSD objects works on islandoradev.

Comments are in code, but for the most part this was realignment to Islandora's OSD. Our module relied on deprecated calls and required some updates after our recent upgrade (I do not recall the last time I updated our custom module islandora_openseadragon_paged). With the site running 1.11 this was likely an issue that was missed during QC entirely.

There is a @TODO in code about deprecating this module and using hooks to achieve this (this too, can be made a module) more appropriately.

Benjamin Rosner

Instructional Application Developer Instructional Media and Technology, Barnard Library and Academic Information Services p: 212-854-9005

On Tue, Jun 19, 2018 at 5:41 PM, Martha notifications@github.com wrote:

Looking good to me! I don't think the highlight not working on the issue object is a bug--the HOCR is stored on the page level so that's where the highlighting should work, right? And most of the results should be page-level as well. Can you easily explain what was going wrong for OSD to not display?

Thank you, Ben!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/BarnardArchives/digitalcollections.barnard.edu/issues/66#issuecomment-398555465, or mute the thread https://github.com/notifications/unsubscribe-auth/ANhlbH4d0mfEk9DYt_fXvQCnszsJ6IJEks5t-W_1gaJpZM4UsAlB .