BarneyShi / Team1-VanHouse

CPSC455 course project.
0 stars 1 forks source link

SearchBar style #32

Closed tyxxxx closed 3 years ago

tyxxxx commented 3 years ago

Hi All,

I finished my part. I made two videos, you can check on Slack

Now, you can see the format change. Click the search icon to filter accordingly, and click Cancel to return to all posts interfaces.

屏幕快照 2021-07-26 下午7 03 28

Other changes I made:

  1. The search bar style
  2. filtering by keyword (title and address)
  3. When the minimum price is greater than the maximum price, a prompt will appear
  4. Userlist can filter out the posts corresponding to each user. After filtering, you can still search the price and location of the filtered Posts again
  5. I removed all CSS formats from the userlist.js
BarneyShi commented 3 years ago

@tyxxxx The other thing is to remove http://localhost:4000 from API calls so we can deploy our project later.

NaithanB commented 3 years ago

@BarneyShi good point - I'll need to do that too.

NaithanB commented 3 years ago

Awesome that the search matches partial words. The searches are working well for me.

I found a couple picky details that might be worth considering.

Not for this PR but for later - I think we need some sort of “no posts found” text indication to appear when there are no results to show. Otherwise, if the user’s page loads really quickly and they don’t see the spinner, they might think the page is stuck waiting for the results. This might be a good thing for me to implement since it would be more to do with the PostCollection.

tyxxxx commented 3 years ago

@NaithanB I changed searchAll() to setQuery("") and deleted the searchbar copy.js, you can check it.

For mobile sized devices, I think we need discuss more detailed. Now I just put these in the gray box. I tried to divide these into two lines on the mobile sized devices, but the display on the computer sized devices display doesn't look so beautiful. Yes, your post button also needs to be adjusted. We can discuss it tmr

NaithanB commented 3 years ago

Great. Thanks for making those changes! That's working well. One more minor thing (sorry) - could the input type for the price inputs be set to "number" instead of "text" on lines 58 and 64 in SearchBar? At the moment we could type in text in those fields and get an error.