search

BarneyShi / Team1-VanHouse

CPSC455 course project.
0 stars 1 forks source link

Login alerts #48

Closed parksj23 closed 3 years ago

parksj23 commented 3 years ago

I made any error messages appear as react bootstrap alerts instead of a window.alert (but not for successful register, etc) for consistency.

NaithanB commented 3 years ago

Hi @parksj23, the react bootstrap alerts look nice in the login window and the forgot password window! Should the registration page also be showing bootstrap alerts too? I only see the window alerts and the password help text when I try to enter invalid registration info.

NaithanB commented 3 years ago

Oh I see what's happening. I'm getting to the window.confirm("Please re-check your registration information") call in the else branch in the Header.js file on submit. I do see the react alert for a duplicate email. (Should have checked the code first).