BarneyShi / Team1-VanHouse

CPSC455 course project.
0 stars 1 forks source link

highlight the selected user icon & mobile-size #49

Closed tyxxxx closed 3 years ago

tyxxxx commented 3 years ago

Hi All,

  1. highlighting the selected user icon when filtering by user so that users can see when there is a search happening
  2. Don’t allow typing non-numerical text into price filters
  3. As Barney said last week: when the interface is the mobile-size, users need to click user list to load user
  4. Adding a scroll bar to the user list(When the screen is half the size, you can see the scroll bar)
屏幕快照 2021-08-05 上午4 51 32 屏幕快照 2021-08-05 上午4 51 41
NaithanB commented 3 years ago

Hi Yuxin, Thanks! The user list looks nice! The city selector looks way nicer on Safari now too.

Just a couple things that I think could be changed:

NaithanB commented 3 years ago

When I'm in mobile sized view, I'm not sure it's obvious that that clicking on the user list will expand it. Is there a way to show visually that it's clickable? Maybe a dropdown arrow icon or something? It is a nice addition though!

tyxxxx commented 3 years ago

@NaithanB Sure! can you check the message on slack?

parksj23 commented 3 years ago

@tyxxxx I have the same suggestions as Naithan so I've approved the changes since you are already aware of them. In particular, if we could click on the user again to deselect (or something like that), and add something to the user list in mobile view to make it clear that it will expand if clicked. Otherwise it looks great!

tyxxxx commented 3 years ago

Hi All,

Now

  1. the price input fields are wider
  2. For user list, the margin for the inner div extend closer to the edge
  3. I add an icon for user list, so it's obvious that that clicking on the user list will expand it

I don't think the function of "click inside the userlist component but not on a specific user" will be done for the time being. I don't know how to do it at present haha. The cancel button would deselect any selected users, so keep it like this. You can test it. I think it is ready to merge @NaithanB @parksj23 @BarneyShi

I will open a new pull request, which is the function of switching Chinese. I have done most of it, but the account interface. I need Barney to help me finish this part