Closed tyxxxx closed 3 years ago
Hi Yuxin, Thanks! The user list looks nice! The city selector looks way nicer on Safari now too.
Just a couple things that I think could be changed:
When I'm in mobile sized view, I'm not sure it's obvious that that clicking on the user list will expand it. Is there a way to show visually that it's clickable? Maybe a dropdown arrow icon or something? It is a nice addition though!
@NaithanB Sure! can you check the message on slack?
@tyxxxx I have the same suggestions as Naithan so I've approved the changes since you are already aware of them. In particular, if we could click on the user again to deselect (or something like that), and add something to the user list in mobile view to make it clear that it will expand if clicked. Otherwise it looks great!
Hi All,
Now
I don't think the function of "click inside the userlist component but not on a specific user" will be done for the time being. I don't know how to do it at present haha. The cancel button would deselect any selected users, so keep it like this. You can test it. I think it is ready to merge @NaithanB @parksj23 @BarneyShi
I will open a new pull request, which is the function of switching Chinese. I have done most of it, but the account interface. I need Barney to help me finish this part
Hi All,