search

BarneyShi / Team1-VanHouse

CPSC455 course project.
0 stars 1 forks source link

finished translation #51

Closed tyxxxx closed 3 years ago

tyxxxx commented 3 years ago

Finished

tyxxxx commented 3 years ago

@NaithanB

NaithanB commented 3 years ago

Looks good. There's a small bug where making a new post while translating will set the payment period to always display in the translated language. It's easy to fix though. It also impacts the edit post function but it's the same fix. I can do it after we merge.

NaithanB commented 3 years ago

Actually, I'll just push the fix to this branch since it's super small (2 lines). I haven't changed the editPost component though because I forgot @BarneyShi changed the setup slightly. Barney, do you want to update that?

BarneyShi commented 3 years ago

@NaithanB No problem. I will do it.

BarneyShi commented 3 years ago

@NaithanB In editPost, I found Yuxin already translated the texts of payment period. It displays correctly as I checked

NaithanB commented 3 years ago

@BarneyShi, did you create a new post, go to the post detail page, switch the language, change the payment period, update the post with the new payment period, then check the main page in English? I think if you do that, the payment period wont display in English anymore because the translated text is pushed to the database. That's what happened for me anyway.

BarneyShi commented 3 years ago

@NaithanB Oh I see, that's the bug. I will do it later. Thanks for spotting that!

tyxxxx commented 3 years ago

@NaithanB @parksj23 @BarneyShi Hi, logging in and out of the account, all posts will be reloaded and loaded for some time. It's a bit of a waste of time, so I optimized the code. Now It won't load posts when I log in or log out at any time, please check that

BarneyShi commented 3 years ago

@NaithanB I fixed the payment period text display bugs. It should work normally now.

NaithanB commented 3 years ago

Looks good. Let's merge!