Closed tyxxxx closed 3 years ago
@tyxxxx Nice. Just a suggestion: we'd better remove the bullets before every use pic coz it's kinda
like this one? In addition, I have a suggestion that I think we can make the post component bigger (such as the screenshot I uploaded above). Now, the post component is smaller and looks a little empty ( I have imported the search component into the post component. So as long as the post component becomes larger, the search component will also become larger)
@tyxxxx Regarding your suggestion about the posts container being a bit small, if you pull the project_2 branch as it is now you'll see that it shows 3 posts per row. I'm not sure why it's only showing 2 posts per row on your branch. Is that something you could look at before you merge?
The issue with the PostCollection being small is because it was moved into a container in App.js. In App.css, I set the PostCollection component to be 80% of the parent when the screen is over 600px wide. Moving it into the container makes it 80% of the size of the container rather than the main page. It's super easy to fix. We just need to change line 87 in App.css from "width: 80%;" to "width: 100%;"
Hi @tyxxxx, I still see the bulletpoints for each user in the user list but it looks like you removed them based on the screenshot. Have you pushed that update?
Yeah @NaithanB @parksj23 I pushed that update! you just need approve this commit. Then I can merge into Project_2
Hi Yuxin, I just changed one thing and pushed the code to this branch.
Thanks for doing that @parksj23! That makes the layout of the components look correct now.
Oh hey, @BarneyShi, are you still able to access your detail component from this branch? I don't think I can on my machine.
@NaithanB No worries. Just need to put the container
inside route path /
.
I think it's better to hide all interface If you want to hide the user list, Either hide them together or make them visible together. what do u think?
Naithan also pointed out one thing I could fix in my css that would fix the issues we found with the checkboxes in the 'Add post' modal. Is it okay if I push my code right now?
Naithan also pointed out one thing I could fix in my css that would fix the issues we found with the checkboxes in the 'Add post' modal. Is it okay if I push my code right now?
@parksj23 How do you think about directly modifying code on project_2
?
Naithan also pointed out one thing I could fix in my css that would fix the issues we found with the checkboxes in the 'Add post' modal. Is it okay if I push my code right now?
@parksj23 How do you think about directly modifying code on
project_2
?
Okay, I'll go do that right now. Just a sec!
Naithan also pointed out one thing I could fix in my css that would fix the issues we found with the checkboxes in the 'Add post' modal. Is it okay if I push my code right now?
@parksj23 How do you think about directly modifying code on
project_2
?Okay, I'll go do that right now. Just a sec!
Pushed my modifications to project_2!
Also, Can I merge this into Project_2?
I think it's good to go. How do you guys think about? @NaithanB @parksj23
Yeah I think it looks okay. The title (my part) looks wonky in the post detail page so I'll try to fix that today or tomorrow but otherwise it looks great!
@NaithanB
@NaithanB
He might not get to this until tomorrow actually.
@tyxxxx Let's merge it and see how it goes.
merge
It would be strange if the text were the same size as the picture, now they are aligned in the center of a line.