BarneyShi / Team1-VanHouse

CPSC455 course project.
0 stars 1 forks source link

Alignment #8

Closed tyxxxx closed 3 years ago

tyxxxx commented 3 years ago
r

It would be strange if the text were the same size as the picture, now they are aligned in the center of a line.

BarneyShi commented 3 years ago

@tyxxxx Nice. Just a suggestion: we'd better remove the bullets before every use pic coz it's kinda

tyxxxx commented 3 years ago
屏幕快照 2021-06-10 下午6 33 05

like this one? In addition, I have a suggestion that I think we can make the post component bigger (such as the screenshot I uploaded above). Now, the post component is smaller and looks a little empty ( I have imported the search component into the post component. So as long as the post component becomes larger, the search component will also become larger)

屏幕快照 2021-06-10 下午6 36 29
parksj23 commented 3 years ago

@tyxxxx Regarding your suggestion about the posts container being a bit small, if you pull the project_2 branch as it is now you'll see that it shows 3 posts per row. I'm not sure why it's only showing 2 posts per row on your branch. Is that something you could look at before you merge?

NaithanB commented 3 years ago

The issue with the PostCollection being small is because it was moved into a container in App.js. In App.css, I set the PostCollection component to be 80% of the parent when the screen is over 600px wide. Moving it into the container makes it 80% of the size of the container rather than the main page. It's super easy to fix. We just need to change line 87 in App.css from "width: 80%;" to "width: 100%;"

NaithanB commented 3 years ago

Hi @tyxxxx, I still see the bulletpoints for each user in the user list but it looks like you removed them based on the screenshot. Have you pushed that update?

tyxxxx commented 3 years ago

Yeah @NaithanB @parksj23 I pushed that update! you just need approve this commit. Then I can merge into Project_2

parksj23 commented 3 years ago

Hi Yuxin, I just changed one thing and pushed the code to this branch.

NaithanB commented 3 years ago

Thanks for doing that @parksj23! That makes the layout of the components look correct now.

NaithanB commented 3 years ago

Oh hey, @BarneyShi, are you still able to access your detail component from this branch? I don't think I can on my machine.

BarneyShi commented 3 years ago

@NaithanB No worries. Just need to put the container inside route path /.

tyxxxx commented 3 years ago

I think it's better to hide all interface If you want to hide the user list, Either hide them together or make them visible together. what do u think?

parksj23 commented 3 years ago

Naithan also pointed out one thing I could fix in my css that would fix the issues we found with the checkboxes in the 'Add post' modal. Is it okay if I push my code right now?

BarneyShi commented 3 years ago

Naithan also pointed out one thing I could fix in my css that would fix the issues we found with the checkboxes in the 'Add post' modal. Is it okay if I push my code right now?

@parksj23 How do you think about directly modifying code on project_2?

parksj23 commented 3 years ago

Naithan also pointed out one thing I could fix in my css that would fix the issues we found with the checkboxes in the 'Add post' modal. Is it okay if I push my code right now?

@parksj23 How do you think about directly modifying code on project_2?

Okay, I'll go do that right now. Just a sec!

parksj23 commented 3 years ago

Naithan also pointed out one thing I could fix in my css that would fix the issues we found with the checkboxes in the 'Add post' modal. Is it okay if I push my code right now?

@parksj23 How do you think about directly modifying code on project_2?

Okay, I'll go do that right now. Just a sec!

Pushed my modifications to project_2!

tyxxxx commented 3 years ago

Also, Can I merge this into Project_2?

BarneyShi commented 3 years ago

I think it's good to go. How do you guys think about? @NaithanB @parksj23

parksj23 commented 3 years ago

Yeah I think it looks okay. The title (my part) looks wonky in the post detail page so I'll try to fix that today or tomorrow but otherwise it looks great!

tyxxxx commented 3 years ago

@NaithanB

parksj23 commented 3 years ago

@NaithanB

He might not get to this until tomorrow actually.

BarneyShi commented 3 years ago

@tyxxxx Let's merge it and see how it goes.

tyxxxx commented 3 years ago

merge