[Feat] API_KEY env - Githubissues

Baroshem / nuxt-medusa

🛍️ Medusa module for Nuxt

https://nuxt-medusa.vercel.app

MIT License

123 stars 9 forks source link

[Feat] API_KEY env #10

Closed runyasak closed 1 year ago

runyasak commented 1 year ago

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR is related to #7. I've created API_KEY env and implemented it on module options.

Scope of work

add API_KEY env and implement on module.ts
update docs and README

Checklist:

[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes (if not applicable, please state why)

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
nuxt-medusa	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 25, 2023 at 8:02AM (UTC)

Baroshem commented 1 year ago

Hey @runyasak

Thanks for the PR however the idea was this feature was different.

There is nothing wrong with passing options as module configuration. What Pooya meant with this bug is that the API Key that is passed as configuration option is later added to the runtime config. In your PR it will still be added there.

So how it should be implemented is to find a way to not add apiKey to the runtime config but pass these options in a different way so that they are not accessible from the public runtime config.

runyasak commented 1 year ago

@Baroshem Sorry, for my misunderstanding. I should ask you for more detail first. I get your point now. I will submit another PR to solve this issue.

By the way, thank you so much for accepting my PR. 😂

Baroshem commented 1 year ago

I will close this PR as it is outdated and there is another PR live :)