fix: move apiKey to private config

Baroshem / nuxt-medusa

🛍️ Medusa module for Nuxt

https://nuxt-medusa.vercel.app

MIT License

130 stars 10 forks source link

fix: move apiKey to private config #17

Closed runyasak closed 1 year ago

runyasak commented 1 year ago

Types of changes

[X] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR is related to #7. Previously apiKey is the public config and exposed, then I move it to the private config.

Checklist:

[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes (if not applicable, please state why)

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nuxt-medusa	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 12, 2023 5:58pm

runyasak commented 1 year ago

Also, could you add a note to the docs that from now, admin requests via apiKey can be done from server utility only :)

I've updated apiKey in docs. Please, check out this commit: 88298b8170b492378c114d4eebad6cef1eb6b017

runyasak commented 1 year ago

@Baroshem @pi0 I've updated as your comments. I'm a beginner at contributing nuxt module. By the way, thank you for your kind and advice. Don't hesitate to comment or give feedback on my code. Please, review my code again, and if you have any comments or updates, let me know. 😁

Baroshem commented 1 year ago

Hey,

I will take a look at it after the weekend!

Enjoy!

runyasak commented 1 year ago

Hey,

I will take a look at it after the weekend!

Enjoy!

Thank you so much. I'm looking for your updates. Really want to learn from your code. 😁

Baroshem commented 1 year ago

Nicely done @runyasak

I will p[ublish a package later today :)