Baroshem / nuxt-medusa

🛍️ Medusa module for Nuxt
https://nuxt-medusa.vercel.app
MIT License
123 stars 9 forks source link

Modified the code so it follows the latest official Nuxt's Module Author Guide and bumped the medusa package version #32

Closed dimitrio-m closed 8 months ago

dimitrio-m commented 8 months ago

Modified the code so it follows the latest official Nuxt's Module Author Guide and bumped the medusa package version.

Types of changes

Description

Hello @Baroshem as I said in the issue #31, I had a problem that seemed related to the npm package release. I tried to execute the module locally and it worked great, but I couldn't get it to work when importing the module as an npm package. I started to investigate and noticed that the module was not following the latest Nuxt Module Author Guide, so I updated the packages, added some default configuration to TypeScript that the builder needed and finally tested the module by uploading it to an npm registry (it was my first time doing that) and it worked. I imported the test package in the project that I had the issue with in the first place, and it was a success.

Checklist:

I don't know if this changes are ok, or if we need to change another thing or do further testing (first time contributor here :smiley: ). I tried executing the tests and they passed. I also tried to execute the playground example and it worked great. I also tried the package in the project that I had the problem in the first place and it worked there too.

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-medusa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 11:52am
Baroshem commented 8 months ago

Hey,

Thanks for this PR! I will review it and give you some hints :)

And I am pretty happy that you are contributing. Keep it going!

dimitrio-m commented 8 months ago

One small comment to resolve :)

That's right! That was an oopsie, I forgot to change back the name when I uploaded it to the npm registry for testing. Let me do a commit to fix it.

dimitrio-m commented 8 months ago

Sorry I made a typo on the last commit

Baroshem commented 8 months ago

No worries Buddy. I am merging this PR and will release a new version soon! :)