Closed GalacticHypernova closed 6 days ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nuxt-security | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 13, 2024 11:50am |
@Baroshem can we introduce some dependencies for some of the tests? (like websockets) Or should the module stay dependency-free?
@GalacticHypernova
Hey there! The best would be to remain deps free 🙂
How would we test websockets in such case? Through nitro's built in websocket system?
This will be refactored, the issue has been identified and is unrelated to the module, I'll open a PR in the responsible repo
Thanks for investigation @GalacticHypernova. Should we close this PR or remain as is?
It depends. Would you like me to make a custom data reading method to not rely on h3's?
I dont think so. We are relying in H3 so I wouldnt test any other setup
In that case we can close this, I forwarded the issue to h3 =)
Types of changes
Description
This is a WIP PR to add support for reading messages from websockets, fixing #472 . It relies on the underlying socket in the connection and is therefore experimental. Due to the inability to test the module locally as stackblitz always regenerated the necessary file, I am adding this here to experiment with.
Checklist: