Open gdzqzzx opened 3 years ago
Thanks @gdzqzzx I'm happy to see your work laid out like this. The usual practice is to make separate pull requests for each change, so that I can accept them separately. But don't worry about it - the changes are small enough that I can easily work my way through them.
Some points:
I worked out that that the ThumbnailLocation
and WaveformLocation
fields were from the Mac version of NVivo 12, so I'll adapt your changes accordingly.
I'm not convinced that the --drop
flag is a useful addition. The idea is that the NormaliseNVP
and DenormaliseNVP
scripts do as they say, nothing more or less. To do a finer level of detail I prefer that the user use the mssqlAttach
script followed by Normalise
then (if they want) mssqlDrop
.
Also, wasn't there another bug you found where StartY
was 0-based while StartX
was 1-based (or was it the other way around)?
Thanks for your reminding @jschultz , I have pushed a new commit on StartY fixing, but I failed to find a way to make a new pull request for this new commit, sorry about that.
For the StartY bug, I''m not pretty sure whether it IS a bug: in my version of nvp file, NVivo StartX
is 0-based, but NVivo StartY
is already 1-based (and I can use StartY
directly to merge Tagging with RowId in original datasets). So what I did is just remove the add-1 action on StartY
.
As for the --drop
flag, I agree with you and I added it just for my project‘s convenience. Maybe I shall try your method on it later.