search

BarryCarlyon / minify

Automatically exported from code.google.com/p/minify (personal copy)
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Minify doesn't detect all scripts and/or css. #230

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Minify version:
PHP version: latest (downloaded same day as this posting)

What steps will reproduce the problem?
1. use the bookmarlet to detect scripts and it doesn't detect them all on 
keepskatinbro.com.

Original issue reported on code.google.com by TruSktr on 14 May 2011 at 2:18

GoogleCodeExporter commented 9 years ago 
It will only return JS URLs on the same domain. What's an example URL that it 
missed that Minify could actually serve? 

BTW, I like the site; I've skated on and off since about '87 and still follow 
it pretty closely on the web at least.

Original comment by mrclay....@gmail.com on 16 May 2011 at 6:31

GoogleCodeExporter commented 9 years ago 
Wow, cool, that's a nice coincidence! Everything I do ties into skateboarding 
somehow. :D I love it.

It appears that minify won't recognize URLs like these: 
http://keepskatinbro.com/wp-content/plugins/nextgen-gallery/shutter/shutter-relo
aded.css?ver=1.3.0

The simple fix would be to have minify strip the ?get content before doing 
anything else with the URL.

Original comment by TruSktr on 16 May 2011 at 9:12

GoogleCodeExporter commented 9 years ago 
Agreed. Just curious, have you tried one of the WordPress plugins that 
integrate Minify? WP Minify, W3 Total Cache, etc? Those might give you some 
easier config options than using Minify out-of-the-box, but I haven't tried 
them myself.

Original comment by mrclay....@gmail.com on 16 May 2011 at 10:33

GoogleCodeExporter commented 9 years ago 
Yeah, i've tried them. But they're just not as customizable as using minify 
out-of-the-box; something little thing always ends up breaking for me. I'll 
have better luck just removing all the scripts from wordpress, and placing them 
manually in the header or footer in the exact order that I need them. Sometimes 
it also seems that the minify interface is easier to use than the plugin 
interfaces! Minify interface + pasting the url in the theme manually seems to 
be the cleanest solution since I'm always inside the code anyways; the code is 
my GUI. :D

Original comment by TruSktr on 18 May 2011 at 6:58