search

Barteks2x / 173generator

GNU Lesser General Public License v3.0
20 stars 16 forks source link

Saplings don't grow #13

Closed kurisubrooks closed 7 years ago

kurisubrooks commented 7 years ago

In the latest build, saplings don't appear to grow, not normally nor with bone meal. This causes quite a problem for both survival and creative players using this plugin.

Barteks2x commented 7 years ago

Are you sure there is enough space for them to grow? Are there any errors in console?

If it's neighter, then something bust have changed in bukkit.

kurisubrooks commented 7 years ago

Yes, there's plenty of room. I even tried on a block in the middle of the sky. Even after 2 stacks of bonemeal there was no growth at all.

It was not working in the 1.8 build also, so i'm guessing it's definitely on Bukkit's end.

My friend managed to get them working again with a modified build he made from your repo, he told me to tell you

in the place where you check if it's LEAVES or AIR, add an OR clause for SAPLING

He would submit a PR, but he couldn't get Spruce saplings to work, and his repo is too dirty

cc: @justin97530

Barteks2x commented 7 years ago

That was something I didn't expect. Beta version just checked if the block is transparent but that also makes trees replace glass and a few other transparent blocks which is not good and I tried to avoid it. I guess I tried too hard.

kurisubrooks commented 7 years ago

👏 Your efforts are greatly appreciated regardless of any bugs that may exist

Barteks2x commented 7 years ago

I will debug and fix it tomorrow.

kurisubrooks commented 7 years ago

Any progress? 😄

Barteks2x commented 7 years ago

Still working on it, I had to change quite a bit of code to get trees to generate the right way.

I also found something interesting: beta 1.7.3 doesn't need to check for sapling in tree generation code because when attempting to generate tree, the sapling is temporarily removed: https://github.com/Bukkit/mc-dev/blob/1a792ed860ebe2c6d4c40c52f3bc7b9e0789ca23/net/minecraft/server/BlockSapling.java#L37-L53

kurisubrooks commented 7 years ago

Huh. Interesting logic on Bukkit's behalf. Glad to see you're working on the bug fix though 🙂

On Sun., 9 Oct. 2016, 7:37 pm Bartosz Skrzypczak, notifications@github.com wrote:

Still working on it, I has to change quite a bit of code to get trees to generate the right way.

I also found something interesting: beta 1.7.3 doesn't need to check for sapling in tree generation code because when attempting to generate tree, the sapling is temporarily removed: https://github.com/Bukkit/mc-dev/blob/1a792ed860ebe2c6d4c40c52f3bc7b9e0789ca23/net/minecraft/server/BlockSapling.java#L37-L53

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Barteks2x/173generator/issues/13#issuecomment-252473039, or mute the thread https://github.com/notifications/unsubscribe-auth/AGAAC1bCqmEDJGM4mhS71zaF9aJUNKBOks5qyKe_gaJpZM4KKgvJ .

Barteks2x commented 7 years ago

It should work now, also the bukkit API to generate trees is now used correctly (or at least I hope so).

kurisubrooks commented 7 years ago

I'll be able to test in about an hour. Thanks so much!

On Sun., 9 Oct. 2016, 8:35 pm Bartosz Skrzypczak, notifications@github.com wrote:

It should work now, also the bukkit API to generate trees is now used correctly (or at least I hope so).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Barteks2x/173generator/issues/13#issuecomment-252475807, or mute the thread https://github.com/notifications/unsubscribe-auth/AGAAC8S9DytsdZCH4ZzOi5LwTRv0p85Iks5qyLVVgaJpZM4KKgvJ .