BartmanAbyss / vscode-amiga-debug

One-stop Visual Studio Code Extension to compile, debug and profile Amiga C/C++ programs compiled by the bundled gcc 12.2 with the bundled WinUAE/FS-UAE.
GNU General Public License v3.0
312 stars 39 forks source link

Makefile executes commands with sh #103

Closed dr-oaab closed 2 years ago

dr-oaab commented 2 years ago

When I tried to build the initialized amiga project I got the following error

> Executing task: c:\Users\david\.vscode\extensions\bartmanabyss.amiga-debug-1.4.0\bin\gnumake.exe -j4 <

Compiling main.c
Compiling support/gcc8_c_support.c
Assembling support/gcc8_a_support.s
Assembling support/depacker_doynax.s
/usr/bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
/usr/bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
/usr/bin/sh: -c: line 1: syntax error: unexpected end of file
/usr/bin/sh: -c: line 1: syntax error: unexpected end of file
gnumake: *** [Makefile:51: obj/main.o] Error 1
gnumake: *** Waiting for unfinished jobs....
gnumake: *** [Makefile:51: obj/gcc8_c_support.o] Error 1
AsAsesmsbelmebrl emre smseasgseasg:e
sF:a
tFaalt aelr reorrr:o rc:a nc'atn 'ctr ecarteea toeb jo/bdje/pgaccck8e_ra__dsouypnpaoxr.to.:o :N oN os uscuhc hf ifliel eo ro rd idriercetcotroyr
y
gnumake: *** [Makefile:57: obj/depacker_doynax.o] Error 1
gnumake: *** [Makefile:57: obj/gcc8_a_support.o] Error 1
The terminal process "C:\WINDOWS\System32\cmd.exe /d /c c:\Users\david\.vscode\extensions\bartmanabyss.amiga-debug-1.4.0\bin\gnumake.exe -j4" terminated with exit code: 2.

I think this is because Git on my system has its tools in path, and gnumake somehow finds sh and tries to use it to execute the commands in Makefile.

dr-oaab commented 2 years ago

Adding SHELL = cmd.exe to the beginning of Makefile resolves the issue.

BartmanAbyss commented 2 years ago

Glad you figured it out. I will add that fix to the next version.