search

BartmanAbyss / vscode-amiga-debug

One-stop Visual Studio Code Extension to compile, debug and profile Amiga C/C++ programs compiled by the bundled gcc 12.2 with the bundled WinUAE/FS-UAE.
GNU General Public License v3.0
316 stars 39 forks source link

Track source from profile disassembly view #168

Closed grahambates closed 1 year ago

grahambates commented 1 year ago

This adds a mode in the profiler to enable following the timeline position in source files as well as disassembly. It's similar to how it works in the objdump editor when you disassemble an elf file. When this mode is enabled, scrubbing the timeline position on the flame graph will scroll through source locations in the right hand editor. This is similar to what @rjobling proposed in issue #99.

image

I've also added a toggle for the register overlay in the disassembly tab using the same UI pattern. I thought it was useful to be able to disable this when it's obscuring the disassembly content.

image
grahambates commented 1 year ago

@BartmanAbyss are you unsure about this change or do you just need time to review and test? Let me know if there's anything I can do or if you want to discuss.

I'm aware that I'm bombarding you with PRs at the moment and I hope you're ok with this! I've just been pushing fixes and improvements as they've come up while using the extension and I've been aiming to provide working solutions rather than raising issues that create work for you. Is this the best way to collaborate or would you prefer some more upfront discussion?

BartmanAbyss commented 1 year ago

It's all good. Was just a little busy this week and wanted to test this PR first. I appreciate all the improvements you contribute.