BartoszCichecki / LenovoLegionToolkit

Lightweight Lenovo Vantage and Hotkeys replacement for Lenovo Legion laptops.
GNU General Public License v3.0
5.5k stars 246 forks source link

Performance issues ada Lovelace/4070m #1109

Closed BobaFettJr closed 10 months ago

BobaFettJr commented 10 months ago

Rules

Version

2.18.0

OS

Windows 11

Device

Legion 5 pro 7745hx 4070m Gen 8

BIOS version

47ww

What's wrong?

Tested multiple runs on time spy and in various games.

Both sets of runs using afterburner GPU OC leaving both vantage and llt GPU overclock options off.

When using llt over vantage, vantage was disabled via llt and reboot prior to runs.

Runs 1-10 GPU test 1 and 2 only with all custom mode sliders in max positions on legion tool kit (not touching offset) graphics scores 13400-13600

Runs 11-20 using vantage and all sliders in max positions graphics scores 14100-14200

In games....

Mw3 multiplayer various maps 4 hour total gameplay using llt average fps 183-189 with current graphical setup. Crashes on any overclock at 230 core or above. Stable at 220 and below.

Mw3 multiplayer various maps 4 hour total gameplay using vantage average fps 207-223 with same graphical setup. Crashes on overclock above 245 core. Stable at 245 and below with zero crashes.

Hogwarts legacy llt average 150fps crashes at 230 OC

Hogwarts legacy vantage average 170 fps stable at 250 OC and below

Baldur's gate 3 llt average fps 165fps crashes at 230 OC

Baldur's gate 3 vantage average fps 180 stable at 250 and below oc


Not sure what's going on, but you can see a visible and noticable performance degradation using llt over vantage.

Average GPU watts using llt peg to 130w and rarely cross 135w at peaks, and with vantage on exact same settings average GPU watts peg 140w or touch 141-142w at peaks.

Please fix

How to reproduce the bug?

Max every slider using llt benchmark.

Max every slider vantage benchmark.

What is the behavior that you expected?

Same performance using both software.

However using llt results in lower performance overall.

Logs

Will upload in comments

Additional information

Will upload ts scores and screenshots of results

BartoszCichecki commented 10 months ago

Please fix

Fix what? Custom mode settings are applied in the same way both in Vantage and in LLT which has been verified by many users over last months and the way it works isn't different from Gen 6 or 7.

Neither LLT nor Vantage does anything special in custom mode - only when you switch to it, values are sent to EC which takes care of the rest. Additionally, you are using different overclock values and how that affects performance is unknown due to how curves are handled. Only difference might be (assuming you have more than one power plan in Windows) is that when in Custom mode is selected in LLT, it will use Balance power plan unless configured otherwise.

Neither Vantage nor LLT defines how many peak W dGPU will use, so when you say "with LLT it reaches 135W" and "with Vantage it crosses 140W" that is not up to Vantage nor LLT.

BobaFettJr commented 10 months ago

Had another user test with 4080 GPU and they had no issues. So maybe just 4070 and below or just 4070 related or related to gen 8 AI chips LA1 and LA2-Q?

BobaFettJr commented 10 months ago

As far as power plans I had a custom plan for both programs that was used.

BobaFettJr commented 10 months ago

Should also mention this was consistent with 2 separate laptops both same specs has vantage performing higher

BartoszCichecki commented 10 months ago

@BobaFettJr can you attach a log that includes opening Custom Mode settings window? Issue #1111 exposed a potential issue where cTGP might have not be set properly on AMD platforms.

BartoszCichecki commented 10 months ago

Closing due to inactivity.