BartoszCichecki / LenovoLegionToolkit

Lightweight Lenovo Vantage and Hotkeys replacement for Lenovo Legion laptops.
GNU General Public License v3.0
5.03k stars 230 forks source link

Low keyboard backlight brightness is not low #1318

Closed awesomenow42 closed 1 week ago

awesomenow42 commented 3 months ago

Rules

Version

2.22.1

OS

Windows 11 23H2 (22631.3672)

Device

Legion 5 16IRX9

BIOS version

NMCN22WW

What's wrong?

The low brightness level is just below the high and far from the low Vantage. Burns out eyes :/

How to reproduce the bug?

LLT - Keyboard - Preset - Brightness - Low

What is the behavior that you expected?

Low brightness level

Logs

log_2024_06_02_17_20_12.txt

Additional information

The difference is small, it’s not even visible in the photo

photo_2024-06-02_20-28-50

BartoszCichecki commented 3 months ago

How many brightness levels do you have in Vantage? Is the High brightness set in Vantage same as high in LLT?

awesomenow42 commented 3 months ago

How many brightness levels do you have in Vantage? Is the High brightness set in Vantage same as high in LLT?

Vantage also has 2 brightness levels: High and Low. Low is noticeably lower than high. In Toolkit, Low is almost the same as High. I hope not higher, since my keys are hot :D. High end between Vantage and Toolkit feels identical. Toolkit is very convenient and pleasant, except for this incident with brightness. Thank you.

BartoszCichecki commented 3 months ago

I was told by another L5P gen8 user that Vantage on his machine has similar behavior: very small difference between low and high levels.

I am wondering what is going on here, because:

https://github.com/BartoszCichecki/LenovoLegionToolkit/blob/f9e8af4a301bd02958818b04ab433b5639194170/LenovoLegionToolkit.Lib/Controllers/RGBKeyboardBacklightController.cs#L336-L341

As you can see High brightness has value 2, Low has value 1 and 0 is off. That makes me a bit puzzled because as you can see there isn't really anything in between I can send to the RGB controller - these all are integer numbers, so fractions are a no go.

awesomenow42 commented 3 months ago

It's sad, because in Vantage the difference looks like this:

photo_2024-06-03_23-14-40 photo_2024-06-03_23-14-44

But other than that, I don't like Vantage and would like to delete it.

BartoszCichecki commented 3 months ago

Until I get more clarity on this, I can't do much. I suggest using a darker color. For example, instead of settings white R:255 G:255 B:255 set it to dark grey R:128 G:128 B:128 - this way the color will be darker. In fact I am suspecting is that is what Vantage does, because the RGB controller doesn't have many options on 4-zone keyboards.

awesomenow42 commented 3 months ago

Unfortunately, I don’t know how else I can contribute in this issue. However, in Toolkit 2.22.1 and Vantage 10.2403.25.0 I use the exact color R 22 G 75 B 153. Your proposal is interesting, maybe there really is truth in this.

By the way, the Smooth effect also works with lower brightness in Vantage. And in LLT it cannot be done in the form of darker colors.

BartoszCichecki commented 1 week ago

No other user has reported this issue. Closing...