BartoszCichecki / LenovoLegionToolkit

Lightweight Lenovo Vantage and Hotkeys replacement for Lenovo Legion laptops.
GNU General Public License v3.0
5.63k stars 255 forks source link

Bug: cannot install via scoop #1355

Closed WenSimEHRP closed 4 months ago

WenSimEHRP commented 5 months ago

Rules

Version

2.23.0

OS

Microsoft Windows 11 Home China (x64) Build 22631.3737 (23H2)

Device

Legion Y9000P IRX8

BIOS version

KWCN36WW

What's wrong?

Cannot install via scoop

How to reproduce the bug?

run the following command in terminal:

scoop install lenovolegiontoolkit@2.23.0
# or
scoop install lenovolegiontoolkit

What is the behavior that you expected?

Software is installable using scoop

Logs

Here is the log generated by scoop:

❯ scoop install lenovolegiontoolkit
Installing 'lenovolegiontoolkit' (2.23.0) [64bit] from 'extras' bucket
Loading LenovoLegionToolkitSetup.exe from cache.
Checking hash of LenovoLegionToolkitSetup.exe ... ok.
Extracting LenovoLegionToolkitSetup.exe ... ERROR Exit code was 1!
Failed to extract files from C:\Users\jerry\scoop\apps\lenovolegiontoolkit\2.23.0\LenovoLegionToolkitSetup.exe.
Log file:
  ~\scoop\apps\lenovolegiontoolkit\2.23.0\innounp.log

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Extras/issues/new?title=lenovolegiontoolkit%402.23.0%3a+decompress+error

~\scoop\apps\lenovolegiontoolkit\2.23.0\innounp.log

Signature detected: Inno Setup Setup Data (6.3.0)
This is not directly supported, but i'll try to unpack it as version 5602
; Version detected: 6300
Critical error: The setup files are corrupted. Please obtain a new copy of the program.

Is the setup file corrupted?

Additional information

The older version can be installed regularly

❯ scoop install lenovolegiontoolkit@2.22.2
WARN  Given version (2.22.2) does not match manifest (2.23.0)
WARN  Attempting to generate manifest for 'lenovolegiontoolkit' (2.22.2)
Autoupdating lenovolegiontoolkit
Downloading LenovoLegionToolkitSetup.exe to compute hashes!
Loading LenovoLegionToolkitSetup.exe from cache
Computed hash: c8e431d793a1a5e7b39891f2740c59796e2740566dd00de1f40f423a176387b2
Writing updated lenovolegiontoolkit manifest
WARN  Purging previous failed installation of lenovolegiontoolkit.
ERROR 'lenovolegiontoolkit' isn't installed correctly.
Removing older version (2.23.0).
'lenovolegiontoolkit' was uninstalled.
Installing 'lenovolegiontoolkit' (2.22.2) [64bit] from 'C:\Users\jerry\scoop\workspace\lenovolegiontoolkit.json'
Loading LenovoLegionToolkitSetup.exe from cache.
Checking hash of LenovoLegionToolkitSetup.exe ... ok.
Extracting LenovoLegionToolkitSetup.exe ... done.
Linking ~\scoop\apps\lenovolegiontoolkit\current => ~\scoop\apps\lenovolegiontoolkit\2.22.2
Creating shortcut for Lenovo Legion Toolkit (Lenovo Legion Toolkit.exe)
'lenovolegiontoolkit' (2.22.2) was installed successfully!
BartoszCichecki commented 5 months ago

@YisusChrist can you take a look at this?

WenSimEHRP commented 5 months ago

~~Installer file downloaded by scoop, if needed. application.zip~~ nvm this seems to be identical with the installer in the releases page.

YisusChrist commented 5 months ago

It does not seem to be an error related to 'llt' but rather a problem with Inno Setup.

This has been referenced here and here on the Scoop Extras repository.

cscnk52 commented 5 months ago

can be fixed by install another version of innounp

scoop uninstall innounp
scoop bucket add versions
scoop install versions/innounp-unicode
BartoszCichecki commented 4 months ago

Closing as it seems that related issues were resolved.