BartoszCichecki / LenovoLegionToolkit

Lightweight Lenovo Vantage and Hotkeys replacement for Lenovo Legion laptops.
GNU General Public License v3.0
5.54k stars 249 forks source link

Error on startup #141

Closed DeanRelax closed 2 years ago

DeanRelax commented 2 years ago

Describe the bug Upon starting Lenovo Legion Toolkit, an error pops up. LLT works as intended as long as I don't close the error message. If the error message is closed (by clicking OK on the pop-up) LLT also closes after a few seconds.

I have tried LLT versions 2.2.0 and 2.2.1, and the issue is reproducible on both versions. Earlier I've been using versions 1.7.2 and lower, which worked fine and did not give any error messages.

To Reproduce Steps to reproduce the behavior: Start LLT from the shortcut on the desktop.

Expected behavior

LLT to start without any error messages poping up.

Screenshots

image

Environment

Logs

error_2022_07_02_17_17_18.txt log_2022_07_02_17_17_17.txt

BartoszCichecki commented 2 years ago

Yup looks like a bug. What power plans do you have on your system?

BartoszCichecki commented 2 years ago

Hey @DeanRelax,

I have troubles reproducing your issue. Can you please try this early build of 2.3.0 and paste logs that it creates?

LenovoLegionToolkitSetup.zip

DeanRelax commented 2 years ago

Hi @BartoszCichecki

I have 4 power plans listed:

Balanced Legion Balance Mode Legion Performance Mode Legion Quiet Mode

The issue can replicated while using each power plan.

I might gave been changing the settings for plans in the past. Is there any setting in particular that you think could interfere with LLT?

I downloaded the beta-version of LLT from your comment, but it doesn't seem to change anything in regards to the issue. log_2022_07_31_17_44_02.txt

BartoszCichecki commented 2 years ago

I have a real hard time reproducing the issue and figuring out what is wrong, so please try this version too: LenovoLegionToolkitSetup.zip

It will also crash, but maybe it will give a hint about what's going to.

DeanRelax commented 2 years ago

Ran it and here's the logs: log_2022_08_02_18_17_26.txt error_2022_08_02_18_17_27.txt

BartoszCichecki commented 2 years ago

OK, so I am kind of loosing my mind here :D

So here is the plan:

  1. Try this build: LenovoLegionToolkitSetup.zip
    1. Paste logs here.
    2. If it doesn't work uninstall LLT completely from your system. Make sure that %LocalAppData%\LenovoLegionToolkit does not exist, %LocalAppData%\Programs\LenovoLegionToolkit folders are gone.
    3. Try the build from step 1 again.

It seem like no one else reported or has this issue and looking at the latest logs, the thing that happens for you should never happen, but let's see where this takes us. I am really curious about the reason.

PS: sorry for spamming.

BartoszCichecki commented 2 years ago

Try 2.3.0 once it's released. If issue is not resolved there, reopen this ticket.

DeanRelax commented 2 years ago

Hi again. Just wanted to drop by and inform you that I've just tried version 2.3.1, and the error message no longer pops up. Everything works as intended. Thank you for your great support, and thank you for developing this great application!

Btw. have you considered adding functionality to disable/enable Nvidia Ampere dynamic boost and CPU boost? If so, I could stop using LegionFanControl and solely rely on LLT.

BartoszCichecki commented 2 years ago

For some BIOSes (GKCN and HHCN) there will be feature added called "Custom Power Mode" which is available in Legion Zone. It turns power button pink/purple and allows you to adjust CPU and GPU power limits.

Looking that you also have a Legion 5 Pro, you will be able to use it in 2.4.0 :)