BartoszCichecki / LenovoLegionToolkit

Lightweight Lenovo Vantage and Hotkeys replacement for Lenovo Legion laptops.
GNU General Public License v3.0
5.23k stars 237 forks source link

Incorrect parsing of readme when checking for updates #1411

Closed MinionAttack closed 1 month ago

MinionAttack commented 1 month ago

Rules

Version

2.24.0

OS

Windows 11 Pro 23H2 Build 22631.3958

Device

Legion 7 16ARHA7

BIOS version

K9CN46WW

What's wrong?

Today a new update has appeared using the main repository (same as Lenovo Vantage) and when I click to see the readme, it doesn't parse properly and the HTML code appears.

imagen

How to reproduce the bug?

  1. Go to Downloads.
  2. Select Origin > Primary (Recomended)
  3. Click on update.
  4. Check for a Generic DisplayLink Driver for USB Docks and Adapters update. imagen 4.1 Link to the webiste: https://support.lenovo.com/es/es/downloads/ds501908
  5. Click on open readme.

What is the behavior that you expected?

The readme can be read in the window that appears or a browser is opened to view the HTML as it was done for #1382

Logs

N/A

Additional information

Same problem in 2.23.0 (I just upgraded before opening this issue).

BartoszCichecki commented 1 month ago

Good catch. I modified the code to always open the README in a browser - this way I don't have to handle all the weird formats Lenovo is introducing.