BartoszCichecki / LenovoLegionToolkit

Lightweight Lenovo Vantage and Hotkeys replacement for Lenovo Legion laptops.
GNU General Public License v3.0
5.54k stars 249 forks source link

[BUG]: [Ideapad Gaming 3] Touchpad lock notification incorrect after Fn+F10 press #429

Closed decipher3114 closed 1 year ago

decipher3114 commented 1 year ago

Version

2.7.0

OS

Windows 11 22H2

Device

Ideapad Gaming 3

BIOS version

EGCN39WW

What's wrong?

When I turn off touchpad, it shows touchpad on toast.

How to reproduce the bug?

Turn off touchpad by key.

What is the behavior that you expected?

It should show "Touchpad off"

Logs

No logs.

Do you have Lenovo software installed?

Did you disable any Lenovo software using Lenovo Legion Toolkit?

Additional information

No response

BartoszCichecki commented 1 year ago

Can you attach logs?

decipher3114 commented 1 year ago

https://pastebin.com/u4xK4ATz

BartoszCichecki commented 1 year ago

You says you have Hotkeys installed. Does it work when Hotkeys are enabled? The log is very strange.

decipher3114 commented 1 year ago

Ahh, sorry there is no software installed but the lenovo utility service runs, So, I thought you are asking about that. There is no software installed, but service exists. Also, I am not saying that it doesn't turn it off. It does its functionality very well. Only the toast message shows the wrong status always. See this --> https://drive.google.com/file/d/1uDvTgVw83K8-XlPzF9eE3gsirxW5DkSn/view?usp=drivesdk

BartoszCichecki commented 1 year ago

But from the video it seems that when you press F10, the notification pops up, but the toggle doesn't move? Also, it is strange that when you toggle touchpad lock on the dashboard the notifications pops up, because it shouldn't.

decipher3114 commented 1 year ago

Yes, please fix whatever is wrong here. Or tell how can I fix if my device specific.

BartoszCichecki commented 1 year ago

We need to do some more troubleshooting. Install this build and toggle the touchpad lock twice on the dashboard and upload a log from it.

LenovoLegionToolkitSetup_touchpadlock.zip

BartoszCichecki commented 1 year ago

OK, I think I have an idea what is going on. To give you some context: when you use the toggle on the dashboard to turn touchpad lock on/off it is LLT that is responsible for changing the state. If you use the Fn+F10 hotkey, it is the EC in your laptop that is responsible for changing the lock state and to notify about the change. In your case it looks like EC is acting up a little bit, because it notifies (LLT shows notification), but doesn't change the state (this is why notification is always the same).

I am suspecting that the EC got bugged a little. So far it doesn't look like a bug, because all supported models behave as described above. I do not this that your laptop is different in this regard.

Here is some troubleshooting that you need to do:

  1. Install Lenovo Hotkeys - check if it's working there.
  2. Try to reset the EC (instruction below).
  3. If 1 & 2 doesn't work, check if there is a newer BIOS version.

Please let me know what the result of this.

How to reset EC:
Shutdown the laptop, unplug all cables, charger too.
Press and hold power button for 60 seconds, keep holding even if the laptops powers on, release and then power on the laptop by clicking the power button.
decipher3114 commented 1 year ago

As you said, I have no problem with the touchpad button, when the key is pressed, the touchpad does turn off and when pressed again, it turns on again. So, no problem at all. The bug is only the status toast shown on the screen.

decipher3114 commented 1 year ago

Also, I tested with Lenovo hotkeys as well and the working and toast status is both fine. While with toolkit, working is fine, but toast status is wrong. https://drive.google.com/file/d/1gUMnzsGHhdZinhM3syRj6dzyvtc6jjk1/view?usp=drivesdk

BartoszCichecki commented 1 year ago

OK I think I have the full picture now, but I don't have good news.

It seems that on your machine the WMI method for getting touchpad lock state is not returning correct state after Fn+F10 press, however this method works on all Legions correctly. I think that this is another one of these small inconsistencies between different Lenovo laptop line ups.

I will keep this issue open, but since I don't have access to any device that behaves like yours I am not really sure what is the correct method of of checking the state on this model. If someone is willing do some trouble shooting and figure out how to check it I am open to PRs.

decipher3114 commented 1 year ago

Okay, It is fine, I actually never lock the touchpad so, it is fine. Atleast everything else is fine. 👍👍

decipher3114 commented 1 year ago

Also, Can you tell me if there any way I can help you, like showing you system logs or something. Cause I just checking live logs and there is no change while I change keyboard backlight or even touchpad. Nothing in the logs about this.

staring-hamster commented 1 year ago

Hello, I'm having the exact same issue on the same laptop, is there any way I can help on getting this fixed?

Jony-Gays commented 1 year ago

To be honest I faced the exact same problem, I fully understand the problem the poster had, but it seems he didn't describe the problem clearly enough for the developer to understand what was happening. Now, I will describe the problem exactly.

This is actually a very simple problem, first of all, when I enable Lenovo Hotkeys, and I try to use Fn+F* to open or close the microphone or touchpad, there will be the following notification p1e [p1] P1 So far everything is fine.

However when I use the toolbox to close Lenovo Hotkeys, the Fn shortcut notification becomes [P2]. It's like a black board. At the same time I found the reason for its problem.------

  1. Your default setting is the bottom right corner
  2. The size of the notification box is wrong P2

When I reposition the notification box to the center button, I will see "Notification bar with normal content but severe size problems" [P3] P3

This is all the description of the bug

Version

2.9.1

OS Windows 11 22H2

Device Lenovo Legion R7000P2020H

BIOS version LENOVO FSCN26WW, 22/9/9

What's wrong? ^1 If Disable Lenovo hotkeys,Fn+F* can not display the normal notification icon

How to reproduce the bug? Turn off the touchpad or microphone by Fn+F*

What is the behavior that you expected? ^2 It should show "Touchpad off" I will show with Pic

Logs No logs.

BartoszCichecki commented 1 year ago

To be honest I faced the exact same problem, I fully understand the problem the poster had, but it seems he didn't describe the problem clearly enough for the developer to understand what was happening. Now, I will describe the problem exactly.

No, this is a different problem than the one you have.

BartoszCichecki commented 1 year ago

Closing the issue since there doesn't seem to be any easy fix for this issue.