BartoszCichecki / LenovoLegionToolkit

Lightweight Lenovo Vantage and Hotkeys replacement for Lenovo Legion laptops.
GNU General Public License v3.0
4.64k stars 221 forks source link

[FEAT]: Support white backlit keyboards on 2023 Legion 7 Pro (Y9000P 2023) (Machine Type 82WQ) #697

Closed pengweiqhca closed 1 year ago

pengweiqhca commented 1 year ago

Version

2.12.0

OS

Windows 11 22624

Device

Legion Y9000P IRX8H

Is your feature request related to a problem?

No.

How would you like the problem to be solved?

Use legion zone. image

What alternatives have you considered?

No.

Additional information

No response

BartoszCichecki commented 1 year ago

You need to provide more information.

  1. Logs from current version
  2. What type of keyboard backlight is it (white/per-key rgb/4-zone rgb)?
  3. How many backlight levels are there?
  4. What are the current keyboard shortcuts to control the keyboard?
  5. Screen shots of all backlight settings in Legion Zone or Vantage
pengweiqhca commented 1 year ago
  1. Who's log? LLT(folder is empty) or legion zone?
  2. white/per-key
  3. three: 0% 50% 100%
  4. Not found shortcut.
  5. Legion Zone(Vantage not test).

ps: I am a C# developer, I can assist you debuging.

BartoszCichecki commented 1 year ago
  1. Who's log? LLT(folder is empty) or legion zone?

https://github.com/BartoszCichecki/LenovoLegionToolkit#how-to-collect-logs

BartoszCichecki commented 1 year ago

Also,

white/per-key

You mean it's white only or you can set each key color separately?

pengweiqhca commented 1 year ago

Sorry, I misunderstand, Is single color, not per-key.

pengweiqhca commented 1 year ago

log_2023_04_27_10_34_38.txt

BartoszCichecki commented 1 year ago

OK so the place you want to debug is here:

https://github.com/BartoszCichecki/LenovoLegionToolkit/blob/68f341e255d4874cf3461e8c16d14c8d0d3e581f/LenovoLegionToolkit.Lib/Features/WhiteKeyboardBacklightFeature.cs#L15

Please check what value do you have in outBuffer on line 17 (or if you get an exception). It might be that Lenovo either uses a different result code or they changed the interface completely.

pengweiqhca commented 1 year ago

Exception in https://github.com/BartoszCichecki/LenovoLegionToolkit/blob/master/LenovoLegionToolkit.Lib/Features/AbstractDriverFeature.cs#L83.

BartoszCichecki commented 1 year ago

It looks like there is again another method for controlling the backlight unfortunately.

I will need to do some reverse engineering so it will probably take some time.

Zysor commented 1 year ago

Legion Slim 7 16IRH8 (BIOS M0CN27WW) also cannot change change keyboard backlight with FN + Backspace

BartoszCichecki commented 1 year ago

Related #772

BartoszCichecki commented 1 year ago

@pengweiqhca Hey, could you try version 2.14.1, and run SpectrumTester.exe? I would like to see what kind of keyboard do you have. It will also try to adjust brightness as a test to see if the keyboard is responding.

Not relevant anymore for now.

BartoszCichecki commented 1 year ago

I would also appreciate output of this PS command: Get-WmiObject -namespace root\WMI -class LENOVO_LIGHTING_DATA

BartoszCichecki commented 1 year ago

And one last thing: can you test this build? LenovoLegionToolkitSetup.zip

pengweiqhca commented 1 year ago

Sorry, I has sold it for other reasons, I can't test.

BartoszCichecki commented 1 year ago

That's ok, I managed to find someone with 2023 Slim 7 who did some tests and I think it's ok to assume that this will be solved for 2023 7 Pro too.