BartoszJarocki / cv

Print-friendly, minimalist CV page
https://cv.jarocki.me
MIT License
8.71k stars 914 forks source link

Move homepage sections into individual components #37

Open usman1100 opened 6 months ago

usman1100 commented 6 months ago

⚠️ Major Refactor ⚠️

Moving Sections markup into individual components

This PR creates components for sections like personal info, about, projects etc

Reason

The home page has a lot of markup, making it hard to navigate and read. Additional sections will make the readability even worse

Changes

Just took the markup and pasted into a new component just for better readability and ability to add more sections without overcrowding the home page.

The components don't take props, they use the global RESUME_DATA object.

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cv ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2023 7:22pm
VladimirCreator commented 6 months ago

I think it'll be better to get rid of all

import { RESUME_DATA } from '@/data/resume-data'

in

  1. Education.tsx
  2. Personal.tsx
  3. Projects.tsx
  4. Skills.tsx
  5. Summary.tsx
  6. WorkExperience.tsx

and pass all required data as props:

/* page.tsx
*/
<Personal about={...} ... />
<Summary summary={...} />
<WorkExperience work={RESUME_DATA.work} />
<Education education={RESUME_DATA.education} />
<Skills skills={...} />
<Projects projects={...} />
usman1100 commented 6 months ago

@BartoszJarocki Let me know what you think of this