search

Bartozzz / crawlerr

A simple and fully customizable web crawler/spider for Node.js with server-side DOM. Comes with elegant and hell-simple APIs.
https://npmjs.com/package/crawlerr
MIT License
25 stars 7 forks source link

Specify nodejs version #39

Closed Dragnucs closed 6 years ago

Dragnucs commented 6 years ago

Crawlerr is only compatible with nodejs 10.0 and below.

Bartozzz commented 6 years ago

I believe it should work with LTS (~8.11) since I use @babel/preset-env (which in this case behaves exactly the same as @babel/preset-es2015, @babel/preset-es2016 and @babel/preset-es2017 together). Are you sure it is only compatible with >= v10.0?

Dragnucs commented 6 years ago

No it is compatible with <= 10.0. I made some tests to check that using Docker images. Also if you look at Travis CI logs, you'll see builds start to fail at > 10.0.