search

Barts-Life-Science / AzureTRE

An accelerator to help organizations build Trusted Research Environments on Azure.
https://microsoft.github.io/AzureTRE
MIT License
0 stars 0 forks source link

E2E tests don't always clean up after themselves #33

Open TonyWildish-BH opened 4 months ago

TonyWildish-BH commented 4 months ago

Describe the bug I ran some E2E tests on a branch which hadn't been fully updated, and was still using the now-deprecated 'single server' version of MySQL. The E2E tests failed to deploy the shared service for gitea and the airlock as a result, but they did not delete the partially deployed services - they still showed up in the TRE UI and had to be disabled/deleted by hand.

Steps to reproduce

  1. Use a broken template, such that part of the terraform fails. In this case, it was using azurerm_mysql_server instead of azurerm_mysql_flexible_server in templates/shared_services/gitea/terraform/mysql.tf.
  2. Run the E2E tests: make test-e2e-shared-services
  3. Observe that the tests fail for gitea and airlock, and the broken services are left dangling in the TRE portal

Azure TRE release version (e.g. v0.14.0 or main): This was a development branch, but before commit 8cd68b5e83471d9405233773d98cd9a83f311eb9, which should resolve the issue.

Deployed Azure TRE components - click the (i) in the UI:

TonyWildish-BH commented 3 months ago

MS report that they deliberately leave failed E2E resources around for debugging purposes. They claim that E2E should not be run in a production environment, only in standalone dev environments.