search

Bartz24 / SkyResources

The Skyblock companion mod for 1.9+
GNU General Public License v3.0
10 stars 13 forks source link

Update Redstone Calls every Tick #76

Closed cjm721 closed 6 years ago

cjm721 commented 7 years ago

Was profiling some TPS issues and just noticed this. Not major but causes enough to be of concern especially when the fix is simple.

Should use neighborChanged in Block Call to notify your TE when it needs to check for redstone updates instead of looking every tick. For anything extending TileBase

davqvist commented 6 years ago

Agreed, this is a big problem in my upcoming modpack on our beta testing server. I did some profiling and every Crucible and every casing uses about 2ms. With lots of active players on the server and everyone having at least 2 of each, I have already - only because of these blocks - less than 20 TPS as those tiles use 58ms on the server

Bartz24 commented 6 years ago

I made some changes to redstone checks and world updates. I hope it'll improve in the next version (hopefully releasing later today)