feedback 1 - Githubissues

Barus1993 / Zaverecny-projekt

Evicky web

https://paintednotprinted.netlify.app/

0 stars 0 forks source link

feedback 1 #1

Open jirkasemmler opened 2 years ago

jirkasemmler commented 2 years ago

[ ] skoda, ze scss neni rozdelene do modulu a je vse v jednom dlouhem souboru. Prakticky to nevadi, ale je to dobry zvyk to rozdelovat
[ ] https://github.com/Barus1993/Zaverecny-projekt/blob/f9f4bacc32a9a32adbbfe490fbbf2ca1b9113e0f/_includes/sablona.njk#L9 snazime se nenechavat v kodu mrtvy (zakomentovany) kod
[ ] https://github.com/Barus1993/Zaverecny-projekt/blob/f9f4bacc32a9a32adbbfe490fbbf2ca1b9113e0f/_includes/sablona.njk#L22 ta lomitka "za" by nemely byt potreba
[ ] chvalim odvahu pridat i JS
[ ] je vhodne ty sobuory stahovat https://github.com/Barus1993/Zaverecny-projekt/blob/f9f4bacc32a9a32adbbfe490fbbf2ca1b9113e0f/_includes/sablona.njk#L96
[ ] https://github.com/Barus1993/Zaverecny-projekt/blob/f9f4bacc32a9a32adbbfe490fbbf2ca1b9113e0f/_includes/sablona.njk#L50 ale no tak... mezera v nazvu ?
[ ] https://github.com/Barus1993/Zaverecny-projekt/blob/main/index.html tady nechapu to, ze mas na indexu vse a pak to rozdelujes do sekci? proc je to duplikovane?

jirkasemmler commented 2 years ago

[ ] https://github.com/Barus1993/Zaverecny-projekt/blob/f9f4bacc32a9a32adbbfe490fbbf2ca1b9113e0f/_includes/sablona.njk#L64 toto neni validni v BEM. Ta color by mela byt asi modifier, takze --color
[ ] bylo by fajn, kdyby to scss bylo rozdelene podle vyznamu
[ ] https://github.com/Barus1993/Zaverecny-projekt/blob/f9f4bacc32a9a32adbbfe490fbbf2ca1b9113e0f/scss/style.scss#L178 kdyz uz mas promenne, tak je pouzivej idealne vsude. na tento zapis by se spise hodilo rgba