Bas-Man / rust-decon-spf

A Rust library to deconstruct DNS SPF records
MIT License
16 stars 1 forks source link

allow for macros (%{}) at the start of exists #1

Closed 22ca54d00f05391d6ffee4bc23a5ba60 closed 9 months ago

22ca54d00f05391d6ffee4bc23a5ba60 commented 9 months ago

Modify the regex parsing exists to include %|\w so exists with macros at the start will be captured correctly:

%{i}._i.example.com

22ca54d00f05391d6ffee4bc23a5ba60 commented 9 months ago

Yeah I've been looking at it too and figured I could at least account for this one case I ran into, and thanks for the work on this parser.

On Fri, Nov 3, 2023 at 9:59 PM Adam.S @.***> wrote:

@.**** commented on this pull request.

Again, Thanks for this. I will take look a closer and see what additional tests and logic need to be applied. The RFC on Macro expansion is pretty heavy.

— Reply to this email directly, view it on GitHub https://github.com/Bas-Man/rust-decon-spf/pull/1#pullrequestreview-1713685076, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGE4TNWM42NAEWJDRYLTBLYCWOQJAVCNFSM6AAAAAA634ONVOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJTGY4DKMBXGY . You are receiving this because you authored the thread.Message ID: @.***>