search

BaseMax / GooglePlayWebServiceAPI

Tiny script to crawl information of a specific application in the Google play/store base on PHP.
MIT License
37 stars 9 forks source link

minor fix-ups #12

Closed IzzySoft closed 3 years ago

IzzySoft commented 3 years ago

Feel free to merge and then to cleanup the ReadMe after having investigated the new Wiki pages. I won't have much time tomorrow (having a full-time event to host). If something's amiss, just let me know.

One question still unanswered is whether parseApplication() should filter out the English description when it was left in despite of the language-specific one being present (but "hidden"). The separator in such cases seems to be static, as far as I have seen up to now. Shouldn't be too hard to do – I just didn't want to decide that "over your head". My suggestion is we should do that.

We could bind it to the $debug property (e.g. always clean the comment unless debug is set), at least for a while, to have an easy way to cross-check on empty descriptions (in case the replace "overdid" it). For that, I'd also suggest adding a getter/setter like setDebug(bool), so users could trigger it if they wish to test – without modifying the class file.

Be welcome to open a ticket and assign it to me if you agree.

BaseMax commented 3 years ago

having a full-time event to host

Tell me if I can help you.

Yes, today and tomorrow GitHub has a global event which is a busy day.

BaseMax commented 3 years ago

Be welcome to open a ticket and assign it to me if you agree.

Create issue then PR... Agree, thank you whenever you can send this for a closer look.

IzzySoft commented 3 years ago

Yes, today and tomorrow GitHub has a global event which is a busy day.

Oh? On my end it was an Oracle training course I had to give. Must make a living from something, too :wink:

Create issue then PR...

You want both?