BaseSecrete / rorvswild

Performances & exceptions monitoring for Ruby on Rails applications
https://www.rorvswild.com
MIT License
331 stars 9 forks source link

ActionController::API ignored #15

Closed max-si-m closed 4 years ago

max-si-m commented 4 years ago

Is there is a reason why ActionController::API ignored? Events aren't tracked by rorvswild.

class ApplicationController < ActionController::Base
end

class Api::ApplicationController < ActionController::API
end

ApplicationController.ancestors.include?(ActionController::Base) #=> true
Api::ApplicationController.ancestors.include?(ActionController::Base) #=> false

As I found callbacks implemented in AbstractController::Callbacks

Api::ApplicationController.ancestors.include?(AbstractController::Callbacks) #=> true
ApplicationController.ancestors.include?(AbstractController::Callbacks) #=> true

and after a quick check, I didn't find any restriction.

Thanks a lot, by the way!

alexisbernard commented 4 years ago

Thanks for the report. Callbacks were not setup for ActionController::API. I published a new version gem "rorvswild", "1.5.6" with the fix. Let me know.

max-si-m commented 4 years ago

Thanks for so quick response! Looks like everything is working 💪