search

BaseXdb / basex

BaseX Main Repository.
http://basex.org
BSD 3-Clause "New" or "Revised" License
661 stars 267 forks source link

Improve mixed-case English AM/PM and era indicators #2273

Closed GuntherRademacher closed 5 months ago

GuntherRademacher commented 5 months ago

QT4 tests format-time-021 and format-time-022 currently fail when ICU4J is on the classpath, because AM/PM indicators in mixed case are expected to be Am and Pm, but come out as AM and PM.

I think that the expectation is dubious - would anyone in real life ever want Am/Pm? The mixed-case form of AM/PM and era indicators in English should rather be AM, PM, and BC, AD.

Changing it this way will make those tests fail without ICU4J, too. For getting that fixed, we should add alternate results to format-time.xml. If you agree, I will gladly add a corresponding PR to qt4tests.

ChristianGruen commented 5 months ago

If you agree, I will gladly add a corresponding PR to qt4tests.

I definitely agree.

GuntherRademacher commented 5 months ago

If you agree, I will gladly add a corresponding PR to qt4tests.

I definitely agree.

Done: qt4cg/qt4tests#68.