Fixes for failing tests with respect to function coercion

BaseXdb / basex

BaseX Main Repository.

http://basex.org

BSD 3-Clause "New" or "Revised" License

684 stars 265 forks source link

Fixes for failing tests with respect to function coercion #2286

Closed GuntherRademacher closed 6 months ago

GuntherRademacher commented 7 months ago

This comprises 3 commits:

b74c63b6b2282f3475c8c9c028c9268ca3b2d473: in XQMap.funcType, create a separate FuncType for maps, that reflects a min occurrence of 0 (this fixes xqhof21)
ba82cbdb846c0e14fe3188d9a96ff065a64d045a: moves the map function type creation to MapType, in order to use it in instance tests (this fixes MapTest-061, MapTest-062, MapTest-066)
cb35628e27921c9d0ab74bc96fe655dd8d8f6b1f: make sure that a coerced function comes with all parameters, for passing subsequent arity checks (this fixes function-literal-428, function-literal-430, function-literal-432)

GuntherRademacher commented 7 months ago

Resetting to draft status, because further changes are necessary.

GuntherRademacher commented 6 months ago

The latest commits complete the changes. FuncType now is no longer a superclass of MapType and ArrayType, rather there now is a new abstract superclass FType for the three of them:

Type
 │
 └── FType
     │
     ├── FuncType
     ├── MapType
     └── ArrayType

Also Type now has a new method funcType() that returns the FuncType that can be derived from a Type, if any.

These changes now pass all BaseX and QT4 tests, fixing the seven QT4 tests mentioned earlier. Also some BaseX tests have been adapted due to incorrect expectations.