BasedHardware / Friend

AI wearable necklace
https://basedhardware.com
MIT License
2.06k stars 221 forks source link

App shows -1% when not connected #313

Closed ArchishmanSengupta closed 1 week ago

ArchishmanSengupta commented 1 week ago

The app shows -1% when not connected to the device.

The % should only show when the device is connected, and minimum % value should be 0%

IMG_1588
ArchishmanSengupta commented 1 week ago

@josancamon19 can you assign me this? can take up.

josancamon19 commented 1 week ago

Wondering how this is going @ArchishmanSengupta it'd be great if you could create a Draft PR

ArchishmanSengupta commented 1 week ago

hi, @josancamon19 due to some unforeseeable reason I am off for a few days, kindly assign this to someone else.

raymanyyy commented 1 week ago

Ready for review https://github.com/BasedHardware/Friend/pull/338 The bar is now completely hidden when a Friend is disconnected

bbookman commented 1 week ago

IMO P4, not MVP and does not prevent user from full functionality. It's cosmetic

josancamon19 commented 1 week ago

Thanks @raymanyyy