search

BasedHardware / Friend

AI wearable necklace
https://basedhardware.com
MIT License
2.04k stars 219 forks source link

Show notification on kill #333

Closed Becca-Saka closed 6 days ago

Becca-Saka commented 1 week ago

Triggers a notification when the app is terminated

iOS

https://github.com/BasedHardware/Friend/assets/47469638/fe80b453-c74c-47c5-8ad2-4953308807cf

Android

https://github.com/BasedHardware/Friend/assets/47469638/9fff51c1-5237-4a67-9d81-78e45de402b2

Fixes #318

josancamon19 commented 1 week ago

Awesome, as per the approach I see, you built the code for android and iOS right, and are calling it through flutter. Weren't there any libraries available?

Also, could you please use linting rule of line character length of 120 + default dart format / android studio default rules.

Becca-Saka commented 1 week ago

There are libraries but they haven't been updated in a while.

I will fix this lint issue and tag you again.

Awesome, as per the approach I see, you built the code for android and iOS right, and are calling it through flutter. Weren't there any libraries available?

Also, could you please use linting rule of line character length of 120 + default dart format / android studio default rules.

Becca-Saka commented 1 week ago

@josancamon19 fixed the lint issue.

josancamon19 commented 1 week ago

Also let's set the notification content to: title: Friend Device Disconnected body: Please keep your app opened to continue using your Friend.

Becca-Saka commented 1 week ago

Also let's set the notification content to: title: Friend Device Disconnected body: Please keep your app opened to continue using your Friend.

Got it, I will work on the requested changes tomorrow.

josancamon19 commented 6 days ago

Hi @Becca-Saka are there any updates to this?

josancamon19 commented 6 days ago

I will go ahead and merge this as it is, because it is useful. But looking forward for the remaining changes, thanks!

Becca-Saka commented 6 days ago

Hi @josancamon19 Sorry for the delayed response. I removed the notification request on the start-up

I created a new PR here https://github.com/BasedHardware/Friend/pull/355

I couldn't replicate the Android issues, you raised though.

https://github.com/BasedHardware/Friend/assets/47469638/03820210-f9ed-4f2a-89a8-152e59ab39de

Becca-Saka commented 6 days ago

We should probably move our conversation to the new PR?