BasedHardware / Friend

AI wearable necklace
https://basedhardware.com
MIT License
2.04k stars 219 forks source link

Language coach plug-in #369

Closed bbookman closed 1 day ago

bbookman commented 4 days ago

tested with transcripts and GPT4o output

bbookman commented 3 days ago

Not everyone would know what "follow the prompt structure." means. that is widely open to interpretation. Take a look at the Readme.md PR as an example of what i am thinking.

For example, you have closed my plug-in PR saying they have nothing to do with transcription. So is that a rule?

On Wed, Jun 26, 2024 at 7:16 PM Joan Cabezas @.***> wrote:

@.**** commented on this pull request.

In README.md https://github.com/BasedHardware/Friend/pull/369#discussion_r1655624333:

@@ -149,6 +153,17 @@ Before starting, make sure you have the following installed:

+## Plug-in requirements

I think the only requirement should be follow the prompt structure.

If there's something weird on a PR, of course we will not merge it, but as long as some people find that useful/fun/engaging, I don't see this requirements that strict.

In community-plugins.json https://github.com/BasedHardware/Friend/pull/369#discussion_r1655624484:

@@ -102,5 +102,13 @@ "description": "Provides insight into conversation sentiment", "prompt": "You will be given a conversation transcript. Analyze the content to produce a summary sentiment analysis. Create three categories: Positive Sentiment, Negative Sentiment, and Neutral sentiment. For each category provide 3 bullet points that provide examples from the transcript that represent the category. For each category provide a percentage representing the amount of the transcript that applies to the category. As a summary, define the average sentiment. In other words, if most of the sentiment was neutral, you produce a line 'Average sentiment: Neutral'", "image": "/assets/plugin_images/transcript-improver.png"

  • }
  • },

The plugin is great

— Reply to this email directly, view it on GitHub https://github.com/BasedHardware/Friend/pull/369#pullrequestreview-2143119588, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5ZUQ2AVH6WQQJ3THRABODZJNDWBAVCNFSM6AAAAABJ6YFVI6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBTGEYTSNJYHA . You are receiving this because you authored the thread.Message ID: @.***>

-- Bruce Bookman

josancamon19 commented 1 day ago

Please when adding PR's about plugins only include the plugin content + the new images, I think you have also included on many PR's some stuff that is not related, closing for now.

bbookman commented 1 day ago

Can you please be more specific?

Bruce Bookman

On Sat, Jun 29, 2024 at 9:42 PM Joan Cabezas @.***> wrote:

Please when adding PR's about plugins only include the plugin content + the new images, I think you have also included on many PR's some stuff that is not related, closing for now.

— Reply to this email directly, view it on GitHub https://github.com/BasedHardware/Friend/pull/369#issuecomment-2198398435, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5ZUQ7JS63YCNX7SHT4CL3ZJ5PBJAVCNFSM6AAAAABJ6YFVI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGM4TQNBTGU . You are receiving this because you authored the thread.Message ID: @.***>