Baseflow / ExoPlayerXamarin

Xamarin bindings library for the Google ExoPlayer library
https://baseflow.com
MIT License
153 stars 67 forks source link

Media3 #166

Open ArchangelWTF opened 1 year ago

ArchangelWTF commented 1 year ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Introduces Media3 (Fixes: https://github.com/Baseflow/ExoPlayerXamarin/issues/157)

@martijn00 This fully introduces Media3, I've updated the PackageId's as I think it would break to have media3 published on the current ExoPlayer Id's..

As well as that, if you merge this.. Could you set media3 as the main branch for this repository? This will allow us to keep the current develop and exoplayer branches should we need to do anything with them.

:arrow_heading_down: What is the current behavior?

:new: What is the new behavior (if this is a feature change)?

:boom: Does this PR introduce a breaking change?

:bug: Recommendations for testing

:memo: Links to relevant issues/docs

:thinking: Checklist before submitting

ArchangelWTF commented 1 year ago

@martijn00 When you have time to look this over can you approve and merge this?

Mackly commented 7 months ago

Hi! Is there a reason why this has not been integrated and released to the nuget package ?

ArchangelWTF commented 7 months ago

@Mackly Because it was decided not to be adopted, also Xamarin will have a Media3 package available soon (Went into review this week: https://github.com/xamarin/AndroidX/issues/710)

Mackly commented 7 months ago

Thanks for the reply, I am following closely