search

Baseflow / XF-Material-Library

A Xamarin Forms library for implementing Material Design
https://baseflow.com
MIT License
647 stars 162 forks source link

Some updates for MaterialTextField & MaterialSelectionControl #411

Open kerberosargos opened 3 years ago

kerberosargos commented 3 years ago

This pull request includes added ChoiceCommandParameter for MVVM using and changes for TrailingIcon.

Developer can set Command and CommandParamater or Tap event to TrailingIcon for example show or hide password behavior.

martijn00 commented 3 years ago

Can you rebase to include the latest changes? @softlion can you check this PR?

kerberosargos commented 3 years ago

Can you rebase to include the latest changes? @softlion can you check this PR?

Hello @martijn00 and @softlion I am working new implementations now. I will push 30 minutes later. Please wait to check before this update. Thank you in advance.

kerberosargos commented 3 years ago

Hello again @martijn00 and @softlion I could push yet. Please check and accept PR. Also thank you for your good plugin.

martijn00 commented 3 years ago

@kerberosargos I think you rebase went wrong, you have conflicts.

kerberosargos commented 3 years ago

Hello @martijn00 I have merged conflict, please check again.

kerberosargos commented 3 years ago

Hello @martijn00 can you check this PR please?

martijn00 commented 3 years ago

@softlion Can you check this one before i merge it?

kerberosargos commented 3 years ago

Hello again can you check and merge please?

kerberosargos commented 3 years ago

Hello @martijn00 and @softlion can you check this pr please?