search

Baseflow / XF-Material-Library

A Xamarin Forms library for implementing Material Design
https://baseflow.com
MIT License
647 stars 162 forks source link

Fixed a bug with setresult causing exception, when action was trigger… #442

Closed ramonB1996 closed 2 years ago

ramonB1996 commented 2 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bugfix

:arrow_heading_down: What is the current behavior?

Currently the iOS implementation of MaterialMenuDialog will crash when a user taps twice on an action in the menu.

:new: What is the new behavior (if this is a feature change)?

Will not crash anymore.

:boom: Does this PR introduce a breaking change?

No

:bug: Recommendations for testing

Double-tap an item in the MaterialMenuDialog to see if it does not crash on iOS now.

:memo: Links to relevant issues/docs

https://github.com/Baseflow/XF-Material-Library/issues/439

:thinking: Checklist before submitting

ramonB1996 commented 2 years ago

@martijn00 Thank you for merging the PR. Is it possible to bring out a new version soon? I think there are some bug fixes that should go live for a lot of users :)

ScarletKuro commented 2 years ago

@martijn00 pls update the nuget version, since a lot of important fixes for iOS got merged.