Expose `File` from package `file` - Githubissues

Baseflow / flutter_cache_manager

Generic cache manager for flutter

https://baseflow.com

MIT License

740 stars 429 forks source link

Expose `File` from package `file` #302

Closed sidrao2006 closed 3 years ago

sidrao2006 commented 3 years ago

This prevents the need to unnecessarily have file as a direct dependency

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Update exports

:arrow_heading_down: What is the current behavior?

File is not exported. This means, to type annotate variables, users have to add file as a direct dependencies and import it.

:new: What is the new behavior (if this is a feature change)?

File is exported.

:boom: Does this PR introduce a breaking change?

No

:bug: Recommendations for testing

N/A

:memo: Links to relevant issues/docs

N/A

:thinking: Checklist before submitting

[x] All projects build
[x] Follows style guide lines (code style guide)
[x] Relevant documentation was updated
[x] Rebased onto current develop

creativecreatorormaybenot commented 3 years ago

Can we revert his @renefloor - against what @sidrao2006 proposed, this is a breaking change.

The reason for that is is that it conflicts with dart:io, which means that any code that imported both flutter_cache_manager and dart:io (or universal_io e.g.) will break due to this change.