Closed sidrao2006 closed 3 years ago
cc @renefloor
@sidrao2006 did you see my suggestion in the comment? https://github.com/Baseflow/flutter_cache_manager/pull/304#discussion_r607573131
I think we should only skip sending the eTag while using web, as that is handled by the browser and not by the httpclient on mobile or desktop.
Sorry, missed it
cc @renefloor
Sorry, I've been busy
Sorry, I've been busy
No problem, thanks for merging the PR
:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bugfix / Caching strategy update
:arrow_heading_down: What is the current behavior?
If
eTag
is returned by the server,if-none-match
header is added on subsequent requests which -if-none-match
headers:new: What is the new behavior (if this is a feature change)?
if-none-match
is not added manually. The browser handles this for us.:boom: Does this PR introduce a breaking change?
No
:bug: Recommendations for testing
If tests try matching request headers, remove
if-none-match
from the list.:memo: Links to relevant issues/docs
web.dev article on how the browser handles
eTag
s and adding required headers for the same.Closes #316
:thinking: Checklist before submitting