search

Baseflow / flutter_cache_manager

Generic cache manager for flutter
https://baseflow.com
MIT License
739 stars 426 forks source link

remove need for package:image to shrink package size #319

Closed fzyzcjy closed 3 years ago

fzyzcjy commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

feature

:arrow_heading_down: What is the current behavior?

see https://github.com/Baseflow/flutter_cache_manager/issues/310

:new: What is the new behavior (if this is a feature change)?

see https://github.com/Baseflow/flutter_cache_manager/issues/310

:boom: Does this PR introduce a breaking change?

no

:bug: Recommendations for testing

n/a

:memo: Links to relevant issues/docs

https://github.com/Baseflow/flutter_cache_manager/issues/310

:thinking: Checklist before submitting

renefloor commented 3 years ago

I played around a bit with using this in a listview with images and it is way more performing :)

fzyzcjy commented 3 years ago

@renefloor I played around a bit with using this in a listview with images and it is way more performing :)

Happy to hear that!

renefloor commented 3 years ago

@fzyzcjy I think it's ready to be merged. Do you agree?

fzyzcjy commented 3 years ago

@renefloor Sure!

britannio commented 3 years ago

Great work! I've found this to be significantly more performant than the previous implementation!

fzyzcjy commented 3 years ago

@britannio Happy to hear that!

fzyzcjy commented 3 years ago

By the way, I upgrade the dependency in my production app. Now the apk size reduces by 350KB! (which is not a small thing for a 15MB app) :D