Baseflow / flutter_cache_manager

Generic cache manager for flutter
https://baseflow.com
MIT License
739 stars 426 forks source link

Move file export #324

Closed renefloor closed 3 years ago

renefloor commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix similar to #321

:arrow_heading_down: What is the current behavior?

File is always imported with the library conflicting with dart:io

:new: What is the new behavior (if this is a feature change)?

Give the user of the library a different way to import the file class

:boom: Does this PR introduce a breaking change?

It reverts a breaking change

:bug: Recommendations for testing

:memo: Links to relevant issues/docs

Fixes #320

:thinking: Checklist before submitting

renefloor commented 3 years ago

@sidrao2006, @akadatsky and @aideric. What do you think of this solution? This way the default import

import 'package:flutter_cache_manager/flutter_cache_manager.dart';

won't conflict with dart:io, but you'll still have the option to add an import with

import 'package:flutter_cache_manager/file.dart';
sidrao2006 commented 3 years ago

Yep, this is better than having to add file as a direct dependency

codecov[bot] commented 3 years ago

Codecov Report

Merging #324 (11c6dc5) into develop (b1e9807) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #324   +/-   ##
========================================
  Coverage    74.85%   74.85%           
========================================
  Files           21       21           
  Lines          672      672           
========================================
  Hits           503      503           
  Misses         169      169           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1e9807...11c6dc5. Read the comment docs.