Baseflow / flutter_cache_manager

Generic cache manager for flutter
https://baseflow.com
MIT License
739 stars 427 forks source link

Use https url for git packages #372

Closed sidrao2006 closed 2 years ago

sidrao2006 commented 2 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Dependency changes

:arrow_heading_down: What is the current behavior?

Uses git:// url

:new: What is the new behavior (if this is a feature change)?

Switch to https:// url

:boom: Does this PR introduce a breaking change?

No (dependency update in example)

:bug: Recommendations for testing

N/A

:memo: Links to relevant issues/docs

Unauthenticated git protocol is no longer supported.

https://github.blog/2021-09-01-improving-git-protocol-security-github/

:thinking: Checklist before submitting

codecov[bot] commented 2 years ago

Codecov Report

Merging #372 (f2655a2) into develop (205387b) will increase coverage by 0.10%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #372      +/-   ##
===========================================
+ Coverage    75.28%   75.39%   +0.10%     
===========================================
  Files           23       22       -1     
  Lines          692      691       -1     
===========================================
  Hits           521      521              
+ Misses         171      170       -1     
Impacted Files Coverage Δ
flutter_cache_manager/lib/src/config/config.dart

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 205387b...f2655a2. Read the comment docs.

renefloor commented 2 years ago

Fixed in #368