Baseflow / flutter_cached_network_image

Download, cache and show images in a flutter app
https://baseflow.com
2.4k stars 631 forks source link

[Bug Fix] Fix rethrowing error when fail #908

Closed iballan closed 5 months ago

iballan commented 5 months ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug Fix

:arrow_heading_down: What is the current behavior?

The app crash when user has bad connection.

:new: What is the new behavior (if this is a feature change)?

The app won't crash if user has assign errorListener to the widget

:boom: Does this PR introduce a breaking change?

No

:bug: Recommendations for testing

:memo: Links to relevant issues/docs

https://github.com/Baseflow/flutter_cached_network_image/issues/830 https://github.com/Baseflow/flutter_cached_network_image/issues/830#issuecomment-1866820665

:thinking: Checklist before submitting

renefloor commented 5 months ago

Fixed in PR #891