search

Baseflow / octo_image

A multifunctional Flutter image widget
https://baseflow.com/
MIT License
156 stars 23 forks source link

removed Center around error and placeholder #12

Closed renefloor closed 4 years ago

renefloor commented 4 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bugfix

:arrow_heading_down: What is the current behavior?

Currently the error and placeholder widgets are always centered. This breaks the fit properties of these widgets.

:new: What is the new behavior (if this is a feature change)?

The Center widget is removed. Not sure why that was ever there.

:boom: Does this PR introduce a breaking change?

Yes, the behaviour of the error and placeholder widgets change.

:bug: Recommendations for testing

I tested with the example from issue #11. I could not find any strange behaviour afterward.

:memo: Links to relevant issues/docs

Fixes #11

:thinking: Checklist before submitting