search

Baseflow / octo_image

A multifunctional Flutter image widget
https://baseflow.com/
MIT License
156 stars 23 forks source link

Migrate to null safety #16

Closed renefloor closed 3 years ago

renefloor commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Feature

:arrow_heading_down: What is the current behavior?

Library is not migrate to NNBD

:new: What is the new behavior (if this is a feature change)?

Library is migrated to NNBD

:boom: Does this PR introduce a breaking change?

Yes

:bug: Recommendations for testing

All tests still run

:memo: Links to relevant issues/docs

Waiting for PR https://github.com/brianegan/transparent_image/pull/8 to be merged Waiting for PR https://github.com/fluttercommunity/flutter_blurhash/pull/25 to be published

:thinking: Checklist before submitting

codecov[bot] commented 3 years ago

Codecov Report

Merging #16 (0fdd728) into develop (6d76b78) will decrease coverage by 0.80%. The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #16      +/-   ##
===========================================
- Coverage    43.58%   42.78%   -0.81%     
===========================================
  Files            7        7              
  Lines          195      187       -8     
===========================================
- Hits            85       80       -5     
+ Misses         110      107       -3
Impacted Files Coverage Δ
lib/src/errors.dart 31.25% <0.00%> (ø)
lib/src/fade_widget.dart 3.44% <0.00%> (-5.13%) :arrow_down:
lib/src/octo_set.dart 0.00% <ø> (ø)
lib/src/image.dart 54.71% <68.75%> (-1.77%) :arrow_down:
lib/src/placeholders.dart 100.00% <100.00%> (ø)
lib/src/progress_indicators.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da220f1...0fdd728. Read the comment docs.

renefloor commented 3 years ago

For now the code of transparent image is copied into the test folder and blurhash is disabled.