Closed renefloor closed 3 years ago
Merging #18 (1e14d4a) into develop (0fdd728) will increase coverage by
3.60%
. The diff coverage is57.77%
.
@@ Coverage Diff @@
## develop #18 +/- ##
===========================================
+ Coverage 42.78% 46.38% +3.60%
===========================================
Files 7 8 +1
Lines 187 235 +48
===========================================
+ Hits 80 109 +29
- Misses 107 126 +19
Impacted Files | Coverage Δ | |
---|---|---|
lib/src/image/fade_widget.dart | 3.44% <ø> (ø) |
|
lib/src/image/image.dart | 48.48% <48.93%> (ø) |
|
lib/src/image/image_handler.dart | 62.50% <62.50%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6733515...1e14d4a. Read the comment docs.
:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bugfix for #17
:arrow_heading_down: What is the current behavior?
Currently OctoWidget is using the result of the frameBuilder of the Image widget as placeholder for the new image if you use gaplessPlayback. We should not keep that widget and reuse it as it might be disposed already. We should rebuild the widget.
:new: What is the new behavior (if this is a feature change)?
The new behaviour rebuilds the widget when using gaplessPlayback. To make sure it does use the old widget properties by storing them in the ImageHandler. The ImageHandler can thus rebuild the widget based on the old properties.
:boom: Does this PR introduce a breaking change?
Behaviour changes, but more like you would expect it to happen.
:bug: Recommendations for testing
I changed the example in #17 a bit with a constructed ImageBuilder function. This way the old index is visible while it fades to the new widget with the new index:
:memo: Links to relevant issues/docs
Fixes #17 Should fix https://github.com/Baseflow/flutter_cached_network_image/issues/513 as well.
:thinking: Checklist before submitting