search

Baseflow / octo_image

A multifunctional Flutter image widget
https://baseflow.com/
MIT License
156 stars 23 forks source link

Animate already loaded images when using gappless playback #19

Closed renefloor closed 2 years ago

renefloor commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

:arrow_heading_down: What is the current behavior?

The image widget doesn't show the placeholder when the image is already loaded in memory.

:new: What is the new behavior (if this is a feature change)?

The image widget does show the placeholder when the image is already loaded, but the placeholder is the previous image and gapless playback is enabled.

:boom: Does this PR introduce a breaking change?

No

:bug: Recommendations for testing

Test in real life situations

:memo: Links to relevant issues/docs

Fixes baseflow/flutter_cached_network_image#625

:thinking: Checklist before submitting

renefloor commented 3 years ago

@Kavantix can you try if this fixes your issue? You should be able to test this with cachednetworkimage using dependency overrides.

codecov[bot] commented 3 years ago

Codecov Report

Merging #19 (577229b) into develop (a89e995) will decrease coverage by 2.95%. The diff coverage is 0.00%.

:exclamation: Current head 577229b differs from pull request most recent head d8c2bb2. Consider uploading reports for the commit d8c2bb2 to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #19      +/-   ##
===========================================
- Coverage    46.38%   43.42%   -2.96%     
===========================================
  Files            8        8              
  Lines          235      251      +16     
===========================================
  Hits           109      109              
- Misses         126      142      +16
Impacted Files Coverage Δ
lib/src/image/fade_widget.dart 2.38% <0.00%> (-1.07%) :arrow_down:
lib/src/image/image.dart 46.37% <0.00%> (-2.11%) :arrow_down:
lib/src/image/image_handler.dart 61.79% <0.00%> (-0.71%) :arrow_down:
lib/src/errors.dart 33.33% <0.00%> (+2.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a89e995...d8c2bb2. Read the comment docs.

Kavantix commented 2 years ago

Seems to work nicely! @renefloor