Baseflow / octo_image

A multifunctional Flutter image widget
https://baseflow.com/
MIT License
156 stars 23 forks source link

Properties with defaults cannot be set to null anymore. #3

Closed renefloor closed 4 years ago

renefloor commented 4 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

bug fix

:arrow_heading_down: What is the current behavior?

When you pass down parameters you sometimes accidentally pass down a null value. This should crash the app, but just be set as the default value.

:new: What is the new behavior (if this is a feature change)?

Default values are set when property is null.

:boom: Does this PR introduce a breaking change?

No

:bug: Recommendations for testing

:memo: Links to relevant issues/docs

:thinking: Checklist before submitting

codecov[bot] commented 4 years ago

Codecov Report

Merging #3 into develop will increase coverage by 3.34%. The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop       #3      +/-   ##
===========================================
+ Coverage    39.51%   42.85%   +3.34%     
===========================================
  Files            7        7              
  Lines          205      189      -16     
===========================================
  Hits            81       81              
+ Misses         124      108      -16     
Impacted Files Coverage Δ
lib/src/image.dart 55.88% <50.00%> (+7.57%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea7cf76...cd49984. Read the comment docs.